Skip to content

Conversation

@webmaster442
Copy link
Contributor

JerryScript-DCO-1.0-Signed-off-by: Ruzsinszki Gábor [email protected]

JerryScript-DCO-1.0-Signed-off-by: Ruzsinszki Gábor [email protected]
@akosthekiss
Copy link
Member

Please, DO NOT close the PR every time you make a change. Just (force) push your new commit(s) to the same branch you used to open the PR.

@webmaster442
Copy link
Contributor Author

Please, DO NOT close the PR every time you make a change. Just (force) push your new commit(s) to the same branch you used to open the PR.

Sorry, First I didn't got the Signed-off stuff in the commit right.

@akosthekiss
Copy link
Member

Sorry, First I didn't got the Signed-off stuff in the commit right.

Well, everyone makes mistakes. I sometimes forget the signoff, sometimes I don't forget it but simply get it wrong. Sometimes I forget the style check, or for whatever other reason, the CI goes red. But that was not my point.

My point is that unless you want to abandon your PR, don't close it. If you get the signoff wrong, fix it locally in your branch and push it to github. If you get the builds fail, fix it locally and push it to github. If you get a review from one of the maintainers requesting changes, perform the changes, commit and push the branch to github. Github will catch the push to the branch and it will automatically update the PR.

@ossy-szeged
Copy link
Contributor

LGTM (informal)

@rerobika rerobika added the windows Windows specific label Jun 29, 2020
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows Windows specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants