Update Symbol.split functions for String and Regexp to match new standard #3942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ossy-szeged
reviewed
Jun 26, 2020
tests/test262-es6-excludelist.xml
Outdated
| <test id="built-ins/RegExp/prototype/Symbol.replace/y-set-lastindex.js"><reason></reason></test> | ||
| <test id="built-ins/RegExp/prototype/Symbol.search/get-sticky-coerce.js"><reason></reason></test> | ||
| <test id="built-ins/RegExp/prototype/Symbol.search/get-sticky-err.js"><reason></reason></test> | ||
| <test id="built-ins/RegExp/prototype/Symbol.split/coerce-limit.js"><reason></reason></test> |
Contributor
There was a problem hiding this comment.
Please add a short comment to reason block, for example: won't fix due to spec change - #3942
LaszloLango
reviewed
Jun 30, 2020
…dard In newest ES standard limit parameter is calculated using ToUint32 function instead of ToLength. JerryScript-DCO-1.0-Signed-off-by: Rafal Walczyna [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newest ES standard limit parameter is calculated using
ToUint32 function instead of ToLength.
JerryScript-DCO-1.0-Signed-off-by: Rafal Walczyna [email protected]