Skip to content

Merge jerry-test-suite into jerry tests #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Merge jerry-test-suite into jerry tests #3907

merged 1 commit into from
Jun 17, 2020

Conversation

@rerobika
Copy link
Member

@rerobika rerobika commented Jun 17, 2020

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

@rerobika rerobika added infrastructure Related to GH Actions or the tested targets test Related to testing labels Jun 17, 2020
@rerobika
Copy link
Member Author

rerobika commented Jun 17, 2020

Note: The PR reduces the Travis CI build time with 4 minutes.

dbatyai
dbatyai requested changes Jun 17, 2020
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are leading and trailing new lines in the new test files.

@rerobika
Merge jerry-test-suite into jerry tests
c2d3cc3 
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
@rerobika rerobika force-pushed the merge_jerry_test_suite branch from 76acfa8 to c2d3cc3 Compare June 17, 2020 09:41
@rerobika
Copy link
Member Author

rerobika commented Jun 17, 2020

@dbatyai Thanks, I fixed these issues.

dbatyai
dbatyai approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika mentioned this pull request Jun 17, 2020
Merged
zherczeg
zherczeg approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ossy-szeged
Copy link
Contributor

ossy-szeged commented Jun 17, 2020

LGTM (informal)

@rerobika rerobika merged commit cc4ac49 into jerryscript-project:master Jun 17, 2020
@rerobika rerobika deleted the merge_jerry_test_suite branch June 17, 2020 11:02
@akosthekiss akosthekiss mentioned this pull request Jan 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zherczeg zherczeg zherczeg approved these changes

@dbatyai dbatyai dbatyai approved these changes

Assignees

No one assigned

Labels

infrastructure Related to GH Actions or the tested targets test Related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rerobika @ossy-szeged @zherczeg @dbatyai