Implement async function execution. #3897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 12, 2020
Closed
galpeter
reviewed
Jun 12, 2020
jerry-core/vm/vm.c
Outdated
| } | ||
| else | ||
| { | ||
| uintptr_t diff = (uintptr_t) (&((vm_executable_object_t *) 0x100)->frame_ctx) - 0x100; |
Contributor
There was a problem hiding this comment.
What does the 0x100 represents here? And what do we want to do here?
rerobika
reviewed
Jun 12, 2020
zherczeg
force-pushed
the
do_await
branch
3 times, most recently
from
11d0944 to
72d68ef
Compare
rerobika
requested changes
Jun 16, 2020
zherczeg
force-pushed
the
do_await
branch
2 times, most recently
from
e7a2d53 to
6fb7fcd
Compare
galpeter
reviewed
Jun 16, 2020
| } | ||
| stack_top_p = executable_object_p->frame_ctx.stack_top_p; | ||
|
|
||
| if (executable_object_p->frame_ctx.context_depth > 0) |
Contributor
There was a problem hiding this comment.
This if and the while after it seems to me used in this form multiple times (with seemingly minimal changes). Would it be possible to extract them into a method?
Member
Author
There was a problem hiding this comment.
This is only used twice, and I would not combine them because they do opposite things.
Contributor
There was a problem hiding this comment.
ohh I see one is ref and the other is deref. Sorry for the noise I've missed this.
Member
Author
|
Thank you for the reviews. I hope I did all requests, please check the patch again. |
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3802 should go in first