Skip to content

Fix redeclaration of existing var variables in functions with argument context. #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fix redeclaration of existing var variables in functions with argument context. #3891

merged 1 commit into from
Jun 11, 2020

Conversation

@zherczeg
Copy link
Member

@zherczeg zherczeg commented Jun 10, 2020

Fixes #3888

@rerobika rerobika added the bug Undesired behaviour label Jun 10, 2020
rerobika
rerobika approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbatyai
dbatyai approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 38111c0 into jerryscript-project:master Jun 11, 2020
@zherczeg zherczeg deleted the redecl_rework branch June 11, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbatyai dbatyai dbatyai approved these changes

@rerobika rerobika rerobika approved these changes

Assignees

No one assigned

Labels

bug Undesired behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion 'ecma_find_named_property (prev_lex_env_p, name_p) == NULL' in ecma_op_eval_chars_buffer

3 participants

@zherczeg @dbatyai @rerobika