Add Generator prototype custom dispatcher #3864
Conversation
JerryScript-DCO-1.0-Signed-off-by: Daniella Barsony [email protected]
zherczeg
left a comment
zherczeg
left a comment
There was a problem hiding this comment.
This custom dispatcher is a good idea!
| { | ||
| return ecma_builtin_generator_prototype_object_do (executable_object_p, | ||
| arguments_list_p[0], | ||
| ECMA_ITERATOR_RETURN); |
There was a problem hiding this comment.
What about putting the type into a local variable and call ecma_builtin_generator_prototype_object_do once after the switch?
| arguments_list_p[0], | ||
| ECMA_ITERATOR_RETURN); | ||
| } | ||
| default: |
There was a problem hiding this comment.
Instead of JERRY_UNREACHABLE, the last case (ECMA_GENERATOR_PROTOTYPE_ROUTINE_RETURN) can be a default case, and put an assert which checks the type.
There was a problem hiding this comment.
I'd still insist to the JERRY_UNREACHABLE solution.
There was a problem hiding this comment.
Why? It should be one less check to the compiler.
There was a problem hiding this comment.
The reason why I'm adding custom dispatchers is not just for the binary gain but so the code itself is more readable and uniform.
Imho using the default case with an assert is less "pretty" as simply using the switch cases. I would prefer it the way it is now too.
4 participants
JerryScript-DCO-1.0-Signed-off-by: Daniella Barsony [email protected]