Fix Promise thenable. #3799
Merged
Fix Promise thenable. #3799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
requested changes
May 26, 2020
galpeter
reviewed
May 26, 2020
zherczeg
force-pushed
the
promise_fix
branch
3 times, most recently
from
130af1d to
2036a63
Compare
rerobika
requested changes
May 26, 2020
A single promise can be resolved any number of times due to thenable functions, but each resolver pair can only be called once. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
Member
Author
|
Thank you for the review. Patch is updated. |
galpeter
reviewed
May 27, 2020
| NULL); | ||
| value_p->value = already_resolved; | ||
|
|
||
| value_p = ecma_create_named_data_property (ecma_get_object_from_value (funcs->reject), |
Contributor
There was a problem hiding this comment.
Is it possible to have the same kind of test for "reject" handler like the "resolve" one has?
Contributor
There was a problem hiding this comment.
A test case just like the one added in this PR. But probably reject behaves a bit differently.
Member
Author
There was a problem hiding this comment.
Ok, I get it now. Reject cannot be "delayed", that is a special feature of "resolve". Probably it would be too easy to start an infinite reject loop :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single promise can be resolved any number of times due to thenable functions, but each resolver pair can only be called once.