Fix incorrect assertion in parser_parse_for_statement_start #3795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
requested changes
May 25, 2020
| if (literal_index >= PARSER_REGISTER_START && has_context) | ||
| if (!(literal_index >= PARSER_REGISTER_START | ||
| || !has_context | ||
| || scanner_literal_is_created (context_p, literal_index))) |
Member
There was a problem hiding this comment.
Please simplify this condition by merging the outer negation.
This patch fixes jerryscript-project#3751. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
zherczeg
approved these changes
May 26, 2020
Member
zherczeg
left a comment
zherczeg
left a comment
There was a problem hiding this comment.
LGTM
Assert fixes are so funny.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #3751.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]