Skip to content

Function.prototype[@@hasInstance] should not throw error for not callable this value #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

Function.prototype[@@hasInstance] should not throw error for not callable this value #3773

merged 1 commit into from
May 22, 2020

Conversation

rerobika
Copy link
Member

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

@rerobika
Function.prototype[@@hasInstance] should not throw error for not call…
46852ee 
…able this value

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
galpeter
galpeter approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dbatyai
dbatyai approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 6cd309b into jerryscript-project:master May 22, 2020
@rerobika rerobika deleted the symbol_hasinstance branch June 16, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbatyai dbatyai dbatyai approved these changes

@galpeter galpeter galpeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rerobika @dbatyai @galpeter