Skip to content

Check next token before reparsing identifiers in object assignments. #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2020
Merged

Check next token before reparsing identifiers in object assignments. #3756

merged 1 commit into from
May 18, 2020

Conversation

@zherczeg
Copy link
Member

@zherczeg zherczeg commented May 18, 2020

Fixes #3735.

rerobika
rerobika approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbatyai
dbatyai approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit e01cfda into jerryscript-project:master May 18, 2020
@zherczeg zherczeg deleted the fix_3735 branch May 18, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbatyai dbatyai dbatyai approved these changes

@rerobika rerobika rerobika approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion scope_stack_p > context_p->scope_stack_p in scanner_literal_is_created

3 participants

@zherczeg @dbatyai @rerobika