Skip to content

Conversation

@rerobika
Copy link
Member

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

@rerobika rerobika marked this pull request as draft May 15, 2020 14:43
@rerobika rerobika marked this pull request as ready for review May 21, 2020 13:46
@rerobika rerobika changed the title Implement function.name Implement function name support for script functions and classes May 21, 2020
@rerobika rerobika force-pushed the function_name branch 3 times, most recently from cdea6b7 to ce55a9c Compare May 22, 2020 10:54
@rerobika
Copy link
Member Author

The patch is finally done, and ready for the the review.

Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika
Copy link
Member Author

@galpeter Thanks for the review, the PR is updated.

Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rerobika
Copy link
Member Author

@zherczeg Thanks for the review the PR is updated.

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika merged commit 104001d into jerryscript-project:master May 28, 2020
@rerobika rerobika deleted the function_name branch June 16, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ES2015 Related to ES2015 features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants