Rework the core of class parsing/runtime semantic #3598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
force-pushed
the
rework_class
branch
2 times, most recently
from
2f2fac0 to
3a3cc01
Compare
rerobika
force-pushed
the
rework_class
branch
2 times, most recently
from
3a64615 to
c8a34a7
Compare
rerobika
force-pushed
the
rework_class
branch
4 times, most recently
from
98d60de to
9e8b52b
Compare
ossy-szeged
requested changes
Mar 13, 2020
Changes:
- Use the pre-scanner to provide information for the parser about the existence of the class constructor
- The allocation of the super declarative environment is no longer needed
- The VM frame context holds the information about the this binding status
- Reduce the number of class related VM/CBC instructions
- Improve ecma_op_function_{construct, call} to property set new.target
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
Member
Author
|
@zherczeg @ossy-szeged Thanks for the reviews, I've updated the PR according to them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]