Support ES6 based octal literals #3338
Conversation
rtakacs
force-pushed
the
es6-octal-literal
branch
from
dcebf1a to
99ab518
Compare
jerry-core/parser/js/js-lexer.c
Outdated
| const uint8_t *src_end_p = src_p + length - 1; | ||
|
|
||
| #if ENABLED (JERRY_ES2015) | ||
| if (src_p[1] == LIT_CHAR_LOWERCASE_O) |
There was a problem hiding this comment.
This should be LEXER_TO_ASCII_LOWERCASE (src_p[1) == LIT_CHAR_LOWERCASE_O
There was a problem hiding this comment.
Good catch! You are right :)
rtakacs
force-pushed
the
es6-octal-literal
branch
2 times, most recently
from
6641aa9 to
ea863dd
Compare
rerobika
added
ES2015
rtakacs
force-pushed
the
es6-octal-literal
branch
from
ea863dd to
5abafb5
Compare
ossy-szeged
left a comment
ossy-szeged
left a comment
There was a problem hiding this comment.
It's great to support octal literals. But I think we should make Number(...) too to be able to parse octal numbers too. Of course, it can be done in a follow-up PR.
jerry-core/parser/js/js-lexer.c
Outdated
|
|
||
| if (*source_p < context_p->source_end_p | ||
| && *source_p[0] >= LIT_CHAR_8 | ||
| && *source_p[0] <= LIT_CHAR_9) |
There was a problem hiding this comment.
Are you sure if this check is correct? Maybe I'm wrong, but I can't see what is it for.
There was a problem hiding this comment.
This part of code checks if an octal literal contains 8 or 9 digits (that is not allowed). (A simple copy paste from the original code.) But it can be simplified :)
tests/jerry/es2015/octal.js
Outdated
| // limitations under the License. | ||
|
|
||
| assert (0o10 === 8); | ||
| assert (0O10 === 0o10); |
There was a problem hiding this comment.
Can we add more tests, maybe invalid tests too to check corner cases of the parser.
rtakacs
force-pushed
the
es6-octal-literal
branch
2 times, most recently
from
aa9e5af to
5cd750f
Compare
jerry-core/parser/js/js-lexer.c
Outdated
| if (*source_p < context_p->source_end_p | ||
| && (*source_p[0] == LIT_CHAR_8 || *source_p[0] == LIT_CHAR_9)) | ||
| { | ||
| parser_raise_error (context_p, PARSER_ERR_INVALID_NUMBER); |
There was a problem hiding this comment.
Shouldn't we use the PARSER_ERR_INVALID_OCTAL_DIGIT error here as well?
There was a problem hiding this comment.
Yes, that is more precise error message. I've modified the PR.
rtakacs
force-pushed
the
es6-octal-literal
branch
from
5cd750f to
41d297c
Compare
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs [email protected]
rtakacs
force-pushed
the
es6-octal-literal
branch
from
41d297c to
221a11a
Compare
4 participants
No description provided.