Introduce parser statement flags #3318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
added
enhancement
ossy-szeged
reviewed
Nov 15, 2019
Comment on lines
+88
to
+93
| /** | ||
| * Parser statement attributes. | ||
| * Note: the order of the attributes must be keep in sync with parser_statement_type_t | ||
| */ | ||
| static const uint8_t parser_statement_flags[] = | ||
| { |
Contributor
There was a problem hiding this comment.
I like the idea to remove redundancies and simplify the code base. But it would be great if we could make sure that the enum and this array are in synch.
If we can change the order of enum values, we can do it with macros, for example:
#define PARSER_STATEMENT_TYPE(F) \
F(PARSER_STATEMENT_START, PARSER_STATM_NO_OPTS), \
F(PARSER_STATEMENT_BLOCK, PARSER_STATM_NO_OPTS), \
...
#define PARSER_STATEMENT_TYPE_ES2015(F) ...
#define EXPAND1(A, B) A
#define EXPAND2(A, B) B
typedef enum
{
PARSER_STATEMENT_TYPE(EXPAND1)
#if ENABLED (JERRY_ES2015)
PARSER_STATEMENT_TYPE_ES2015(EXPAND1)
#endif /* ENABLED (JERRY_ES2015) */
} parser_statement_type_t;
static const uint8_t parser_statement_flags[] =
{
PARSER_STATEMENT_TYPE(EXPAND2)
#if ENABLED (JERRY_ES2015)
PARSER_STATEMENT_TYPE_ES2015(EXPAND2)
#endif /* ENABLED (JERRY_ES2015) */
}
Member
Author
There was a problem hiding this comment.
That's a good idea, probably it can be combined with statement_lengths[] as well.
@zherczeg What do you think about it?
Member
There was a problem hiding this comment.
Separate patch. I want to se how it looks like.
Member
There was a problem hiding this comment.
(lines in the length are quite long, and we have 120 char limit)
These flags makes the code more readable also makes the process of introducing a new statement type easier. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
rerobika
force-pushed
the
statm_flags
branch
from
422b30e to
4ac694a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags makes the code more readable also makes the process of introducing a new statement type easier.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]