Add toLength and toInteger operations #3146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
reviewed
Sep 23, 2019
Member
|
Who is using these functions? |
Member
|
@zherczeg Unfortunately currently nobody uses these functions, but these conversion operations also present in ES5.1. To be more precise, in the ES5.1 profile instead of calling these conversion methods, the methods' steps are implemented in all occurrences which increases the binary size. So we are planning to revise these conversion methods all over the code base to be consistent with the 5.1 and the 6.0 standard as well. |
ossy-szeged
reviewed
Sep 25, 2019
Yuyupo
force-pushed
the
tolength
branch
3 times, most recently
from
1387720 to
b241a99
Compare
dbatyai
requested changes
Oct 2, 2019
Yuyupo
force-pushed
the
tolength
branch
2 times, most recently
from
c68f652 to
14f4f68
Compare
dbatyai
requested changes
Oct 3, 2019
dbatyai
requested changes
Oct 3, 2019
JerryScript-DCO-1.0-Signed-off-by: Daniella Barsony [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Daniella Barsony [email protected]