Skip to content

Less comments and per job success/failure messages #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2014

Conversation

ffissore
Copy link
Contributor

@ffissore ffissore commented Sep 5, 2014

This PR introduces a "useDetailedComments" flag: originally when plugin misses rights to changing PR status, it replaces it with comments, leading to many spam emails. This flags silences those emails, leaving just the success/failure ones.
It also introduces per job success/failure messages: it's also possible to use jenkins environment variables in those comments, as they get expanded.
Such comments are sent based on the state of the build and no longer on the presence of a publishedURL.

@ffissore
Copy link
Contributor Author

ffissore commented Sep 5, 2014

This PR:

@cloudbees-pull-request-builder

plugins » ghprb-plugin #176 SUCCESS
This pull request looks good

@ffissore
Copy link
Contributor Author

ffissore commented Sep 5, 2014

Example message: arduino/Arduino#2279 (comment)

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@ffissore
Copy link
Contributor Author

Code has been rebased on current master 1f57cd8

@DavidTanner
Copy link
Contributor

Are you sure you want the detailed flag to only be defined for all jobs? Or did you want that on a per job basis?

@ffissore
Copy link
Contributor Author

I kept them in the singleton because much of the conf was there and because verbose comments were active for all jobs. Sure I would disable such verbosity by default and enable it only on a per job basis.

DavidTanner added a commit that referenced this pull request Sep 29, 2014
Less comments and per job success/failure messages
@DavidTanner DavidTanner merged commit 891fba2 into jenkinsci:master Sep 29, 2014
nosmo pushed a commit to nosmo/ghprb-plugin that referenced this pull request Dec 12, 2018
Less comments and per job success/failure messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants