This repository was archived by the owner on Nov 19, 2024. It is now read-only.
CoverageNode: Fix mergePath for node created from cobertura report #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
============================================
+ Coverage 72.80% 72.83% +0.03%
- Complexity 1028 1031 +3
============================================
Files 88 88
Lines 3824 3825 +1
Branches 440 440
============================================
+ Hits 2784 2786 +2
+ Misses 893 892 -1
Partials 147 147
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anlambert
force-pushed
the
coverage-node-fix-mergepath-for-cobertura
branch
from
0ee3359 to
3b5fe79
Compare
When a coverage node has been created from a cobertura report, the mergePath
method was returning a wrong path if the provided local path contains any
subpaths in it. Those subpaths were prepended to the local path thus doubling
them in the merged path (for instance "a/b/c" was transformed to "a/b/a/b/c").
As a consequence, FileCoverageNode.getPath was returning a wrong file path which
prevented any source file painting and display in the Jenkins UI.
Fix #456
anlambert
force-pushed
the
coverage-node-fix-mergepath-for-cobertura
branch
from
3b5fe79 to
c981227
Compare
uhafner
approved these changes
Jan 25, 2023
|
Thanks for fixing! |
|
I also integrated your changes into https://github.com/uhafner/coverage-model/pull/63. The next version of the coverage plugin will use this model to parse all files. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a coverage node has been created from a cobertura report, the
mergePathmethod was returning a wrong path if the provided local path contains any subpaths in it. Those subpaths were prepended to the local path thus doubling them in the merged path (for instance"a/b/c"was transformed to"a/b/a/b/c").As a consequence,
FileCoverageNode.getPathwas returning a wrong file path which prevented any source file painting and display in the Jenkins UI.Fixes #456.
For the record, I deployed that fix to the Jenkins instance we are using in our development team and source file coverage display is now working when using cobertura reports.
The fix seems pretty harmless to me, surely not the best one but I guess other users of the plugin encountering the same bug will be happy to have the display of coverage painting on source files back as it is quite frustrating to not have it.