This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Fix float precision issue in coverage diff #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
============================================
+ Coverage 72.74% 72.80% +0.05%
- Complexity 1026 1028 +2
============================================
Files 88 88
Lines 3823 3824 +1
Branches 440 440
============================================
+ Hits 2781 2784 +3
+ Misses 894 893 -1
+ Partials 148 147 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
uhafner
suggested changes
Dec 16, 2022
Comment on lines
231
to
232
| //Converting float point to Big decimal and converting back fixes the float precision point problem | ||
| float diff = BigDecimal.valueOf((buildRatio.getPercentageFloat() - referenceRatio.getPercentageFloat())).floatValue(); |
There was a problem hiding this comment.
Can you wrap that code into a method? Then you can write a small unit test that verifies the new behavior.
reshadat
force-pushed
the
floatPointFix
branch
from
6daf1cc to
9b8e885
Compare
uhafner
approved these changes
Dec 19, 2022
plugin/src/main/java/io/jenkins/plugins/coverage/CoverageProcessor.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/coverage/CoverageProcessor.java
Outdated
Show resolved
Hide resolved
|
@uhafner What should be the next steps? Should I do something else for this to be merged and releases in new verison? |
|
No, I just needed to wait for Jenkins to mark this PR as green. Since this code is deprecated anyway there is no need to fix styling issues (I already removed the corresponding checks). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While calculating difference in coverage, there might be a difference even without code change, due to floating point rounding errors. Converting the diff float to BigDecimal with appropriate scale and converting back solves this issue.
Fixes: https://github.com/jenkinsci/code-coverage-api-plugin/issues/191