Fix Python error when ManyToMany relations didn't exist. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reversion_compare/compare.py
Outdated
| """ | ||
|
|
||
| def __str__(self): | ||
| return force_text(_("Field Didn't exist!")) |
There was a problem hiding this comment.
typo: "Didn't" must be lower case, isn't it?
There was a problem hiding this comment.
I've added a commit for that!
cc #54 (comment) :-)
This avoids storing an ugettext value in self.version.
It's value got parsed in `ids = [int(v) for v in self.value]`
causing an `int("F")` call that fails.
Instead, a sentinal value is introduced that can be recognized in the
code, yet output a meaningful message when it's shown to the user.
Fixes jedie#44
jedie
added a commit
that referenced
this pull request
Feb 16, 2016
Fix Python error when ManyToMany relations didn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids storing an ugettext value in self.version.
It's value got parsed in
ids = [int(v) for v in self.value]causing an
int("F")call that fails.Instead, a sentinal value is introduced that can be recognized in the
code, yet output a meaningful message when it's shown to the user.
Fixes #44
This is a rebased version of #54