-
-
Notifications
You must be signed in to change notification settings - Fork 443
feat: add sorted set operations and mixins for RedisCache #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add sorted set operations and mixins for RedisCache #798
Conversation
|
looks good! but this change of structure will need to become consistent with the other kind of commands too, are you willing to make PRs to separate the rest of the commands? I would say, hash and set also need their own mixins... Last but not least, how do you think could bring benefits for going async? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
========================================
- Coverage 38.5% 38.2% -0.3%
========================================
Files 44 48 +4
Lines 3320 3727 +407
Branches 245 301 +56
========================================
+ Hits 1276 1420 +144
- Misses 1799 2006 +207
- Partials 245 301 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What I would personally would aim for in the near future is:
If that sounds good I'm hoping to continue basically today. Except for the last point there is really not much to it. You could review after you've seen the whole package of those 4-5 PRs, so you know I'm not quitting half way. As long as it's realistic from your end these will make it into django-redis without anything big on top of what I've laid out, I'm happy to continue here. Regarding async: I personally don't have much use for async unfortunately, just because my current employer went with sync, although I would really like to use it more. It's not clear to me what the goal and approach would be for django-redis. If you have some github issue or something I'm not seeing let me know. |
See #797.
I can always clean this up or change the structure, but this is how it made sense to me right now.
I can also add more commands to this PR or in a next PR for sorted sets, but these are the main ones I would say, and I'm trying to not blow this up too much.
If there is nothing majorly wrong with this, I'd like to add like another 2-3 PRs worth of commands soon, since I'm using Redis quite heavily right now and I'd rather not have too many custom code in my projects which should probably just go into django-redis. From my point of view, anyway.