Skip to content

Use --no-implicit-optional for type checking #11899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Use --no-implicit-optional for type checking #11899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jax/_src/iree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ class IreeClient:

def __init__(self,
*,
iree_backend: str = None):
iree_backend: Optional[str] = None):
self.platform = "iree"
self.platform_version = "0.0.1"
self.runtime_type = "iree"
Expand Down
1 change: 1 addition & 0 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[mypy]
show_error_codes = True
disable_error_code = attr-defined
no_implicit_optional = True

[mypy-absl.*]
ignore_missing_imports = True
Expand Down