-
Notifications
You must be signed in to change notification settings - Fork 231
Fetch #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fetch #435
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8a9179f
Merge pull request #1 from javascript-tutorial/master
carlosabud 136de82
Article translation
carlosabud 67a3e6f
desalineado
joaquinelio 9f3605e
alinedo II
joaquinelio 8f9776b
alineado III
joaquinelio 72a0e11
alineado IV
joaquinelio 13e16fa
code review + spellcheck
carlosabud 0ac904a
Update task.md
carlosabud e0e6e8d
Update solution.md
carlosabud 971a9c5
Update source.js
carlosabud a05a29e
Update source.js
carlosabud fa2e87a
Update source.js
carlosabud 5db5c01
Update solution.js
carlosabud 0adbb54
Update task.md
carlosabud f9a4eaa
Update solution.md
carlosabud 03baafa
Update 5-network/01-fetch/01-fetch-users/solution.md
carlosabud 7240e96
Update 5-network/01-fetch/01-fetch-users/solution.md
carlosabud cb28605
Update solution.js
carlosabud ca31ef1
Update source.js
carlosabud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
|
|
||
| async function getUsers(names) { | ||
| /* your code */ | ||
| async function obtenerUsuarios(nombresUsuarios) { | ||
| /* Tú código aquí */ | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| # Fetch users from GitHub | ||
| # Fetch de usuarios de GitHub | ||
|
|
||
| Create an async function `getUsers(names)`, that gets an array of GitHub logins, fetches the users from GitHub and returns an array of GitHub users. | ||
| Crear una función async llamada `getUsers(names)`, que tome como parámetro un arreglo de logins de GitHub, obtenga el listado de usuarios de GitHub indicado y devuelva un arreglo de usuarios de GitHub. | ||
|
|
||
| The GitHub url with user information for the given `USERNAME` is: `https://api.github.com/users/USERNAME`. | ||
| La url de GitHub con la información de usuario especifica `USERNAME` es: `https://api.github.com/users/USERNAME`. | ||
|
|
||
| There's a test example in the sandbox. | ||
| En el ambiente de prueba (sandbox) hay un ejemplo de referencia. | ||
|
|
||
| Important details: | ||
| Detalles a tener en cuenta: | ||
|
|
||
| 1. There should be one `fetch` request per user. | ||
| 2. Requests shouldn't wait for each other. So that the data arrives as soon as possible. | ||
| 3. If any request fails, or if there's no such user, the function should return `null` in the resulting array. | ||
| 1. Debe realizarse una única petición `fetch` por cada usuario. | ||
| 2. Para que la información esté disponible lo antes posible las peticiones no deben ejecutarse de una por vez. | ||
| 3. Si alguna de las peticiones fallara o si el usuario no existiese, la función debe devolver `null` en el resultado del arreglo. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.