Skip to content

From the orbital height #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 5, 2020
Merged

From the orbital height #331

merged 7 commits into from
Aug 5, 2020

Conversation

@Leired7
Copy link
Contributor

@Leired7 Leired7 commented Aug 2, 2020

Hay unos cuantos términos que no he traducido: Custom elements, Shadow DOM, CSS Scoping , Event retargeting .... espero al consenso : D

@joaquinelio joaquinelio self-requested a review August 3, 2020 16:48
joaquinelio
joaquinelio requested changes Aug 3, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Consenso? ¡JA! Motivo de pelea.
Pero sí, algunas cosas nos fuimos amoldando...
Tiendo a dejar en inglés más que otros, especialmente en nombres muy específicos.
¿Alguien tradujo "pen-drive" alguna vez?

@javascript-translate-bot
Copy link

javascript-translate-bot commented Aug 3, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Leired7
Copy link
Contributor Author

Leired7 commented Aug 4, 2020

/done

joaquinelio
joaquinelio approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Aunque un segundo revisor probablemente pida más español.
O más aclaraciones. Supongo que ya debe saberse lo que es DOM porque no lo explica acá,
tampoco se si "shadow DOM". Si fuera la primera referencia, decir por qé "shadow".
"DOM interno"?

@Leired7
Copy link
Contributor Author

Leired7 commented Aug 4, 2020

Supongo que "shadow DOM" será porque lo explicara más adelante... ya veremos si pasa el segundo review. Gracias :D

vplentinax
vplentinax approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me gusta la traducción. Fluida y clara. Apruebo con o sin aprobar mi sugerencia en el tema del shadow DOM. Pero esperamos a que el autor nos indique que prefiere antes del merge.

@joaquinelio joaquinelio merged commit 15e3723 into javascript-tutorial:master Aug 5, 2020
@iliakan iliakan mentioned this pull request Aug 5, 2020
Open
@javascript-translate-bot
Copy link

javascript-translate-bot commented Aug 5, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
Copy link
Member

joaquinelio commented Aug 5, 2020

@Leired7
disculpame hice merge sin esperar tu feedback, asumi que estarias de acuerdo
Pero siempre es bienvenido un nuevo PR para proponer cambios

@Leired7
Copy link
Contributor Author

Leired7 commented Aug 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Leired7 @javascript-translate-bot @joaquinelio @vplentinax