Skip to content

Async/await #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 31, 2020
Merged

Async/await #317

merged 8 commits into from
Jul 31, 2020

Conversation

@joaquinelio
Copy link
Member

@joaquinelio joaquinelio commented Jul 23, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team July 23, 2020 02:06
@iliakan iliakan mentioned this pull request Jul 23, 2020
Open
dbritto-dev
dbritto-dev suggested changes Jul 30, 2020
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 30, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio and others added 6 commits July 30, 2020 09:39
@joaquinelio @dbritto-dev
Update 1-js/11-async/08-async-await/01-rewrite-async/solution.md
f0e33f3 
Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 1-js/11-async/08-async-await/01-rewrite-async/task.md
36ade9e 
me da igual...

Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 1-js/11-async/08-async-await/01-rewrite-async/task.md
0d4ae3d 
Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 1-js/11-async/08-async-await/03-async-from-regular/task.md
2d7709d 
ok, latin suena mejor que mal español

Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 1-js/11-async/08-async-await/03-async-from-regular/task.md
e8f5a9e 
¿por? se entiende, pero...

Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 1-js/11-async/08-async-await/02-rewrite-async-2/solution.md
8d85031 
Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio
Copy link
Member Author

joaquinelio commented Jul 30, 2020

/done

@joaquinelio
Update task.md
46acfaa 
s de mas linea 4
maldito teclado
maksumi
maksumi approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@maksumi maksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Vientos!

vplentinax
vplentinax previously approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuímonos! (pronombre enclítico)

@vplentinax
Copy link
Contributor

vplentinax commented Jul 30, 2020

Bueno, realmente debí esperar que @danilobrinu aprobara los cambios. Retiro mi "fuímonos"!

@vplentinax vplentinax dismissed their stale review July 30, 2020 22:42

Other reviewer is here!

@dbritto-dev
Copy link
Contributor

dbritto-dev commented Jul 30, 2020

@vplentinax jajaja aca estoy :p

@vplentinax
Copy link
Contributor

vplentinax commented Jul 31, 2020 •
edited
Loading

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

@dbritto-dev
Copy link
Contributor

dbritto-dev commented Jul 31, 2020 •
edited
Loading

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

@vplentinax
Copy link
Contributor

vplentinax commented Jul 31, 2020

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

Ok.

  1. Ve a "Files Changed"
  2. Comprueba que los cambios fueron aceptados, sugiere nuevos como lo hiciste ya, sino
  3. Ve a la parte superior derecha, botón verde que pone "Review Changes", das click, se te despliega una lista, si estás de acuerdo con los cambios, eliges "Approve", dejas un comentario y listo.

Cualquier duda, nos avisas.

@dbritto-dev
Copy link
Contributor

dbritto-dev commented Jul 31, 2020

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

Ok.

  1. Ve a "Files Changed"
  2. Comprueba que los cambios fueron aceptados, sugiere nuevos como lo hiciste ya, sino
  3. Ve a la parte superior derecha, botón verde que pone "Review Changes", das click, se te despliega una lista, si estás de acuerdo con los cambios, eliges "Approve", dejas un comentario y listo.

Cualquier duda, nos avisas.

@vplentinax listo 👍

@vplentinax vplentinax merged commit c4cce12 into javascript-tutorial:master Jul 31, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 31, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio joaquinelio deleted the asyawa branch August 1, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maksumi maksumi maksumi approved these changes

@vplentinax vplentinax vplentinax left review comments

+1 more reviewer

@dbritto-dev dbritto-dev dbritto-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joaquinelio @javascript-translate-bot @vplentinax @dbritto-dev @maksumi