Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions lib/coffeescript/nodes.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 16 additions & 3 deletions src/nodes.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -1752,10 +1752,23 @@ exports.Class = class Class extends Base

# Add an expression to the class initializer
#
# NOTE Currently, only methods and static methods are valid in ES class initializers.
# When additional expressions become valid, this method should be updated to handle them.
# This is the key method for determining whether an expression in a class
# body should appear in the initializer or the executable body. If the given
# `node` is valid in a class body the method will return a (new, modified,
# or identical) node for inclusion in the class initializer, otherwise
# nothing will be returned and the node will appear in the executable body.
#
# At time of writing, only methods (instance and static) are valid in ES
# class initializers. As new ES class features (such as class fields) reach
# Stage 4, this method will need to be updated to support them. We
# additionally allow `PassthroughLiteral`s (backticked expressions) in the
# initializer as an escape hatch for ES features that are not implemented
# (e.g. getters and setters defined via the `get` and `set` keywords as
# opposed to the `Object.defineProperty` method).
addInitializerExpression: (node) ->
if @validInitializerMethod node
if node.unwrapAll() instanceof PassthroughLiteral
node
else if @validInitializerMethod node
@addInitializerMethod node
else
null
Expand Down
15 changes: 15 additions & 0 deletions test/classes.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -1833,3 +1833,18 @@ test "#4591: super.x.y, super['x'].y", ->
eq 2, b.t
eq 2, b.s
eq 2, b.r

test "#4464: backticked expressions in class body", ->
class A
`get x() { return 42; }`

class B
`get x() { return 42; }`
constructor: ->
@y = 84

a = new A
eq 42, a.x
b = new B
eq 42, b.x
eq 84, b.y