Skip to content

[CS2] Fix #4578: Leading colon shouldn’t throw exception #4662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2017
Merged

[CS2] Fix #4578: Leading colon shouldn’t throw exception #4662

merged 1 commit into from
Aug 24, 2017

Conversation

@GeoffreyBooth
Copy link
Collaborator

@GeoffreyBooth GeoffreyBooth commented Aug 24, 2017

Fixes #4578. Before:

coffee -bpe ':'
TypeError: Cannot read property 'newLine' of undefined
    at Rewriter.<anonymous> (/usr/local/lib/node_modules/coffeescript/lib/coffee-script/rewriter.js:316:113)

After:

./bin/coffee -bpe ':'
[stdin]:1:1: error: unexpected :
:
^

@GeoffreyBooth GeoffreyBooth requested a review from lydell August 24, 2017 06:57
@GeoffreyBooth GeoffreyBooth merged commit 892c469 into jashkenas:2 Aug 24, 2017
@GeoffreyBooth GeoffreyBooth deleted the leading-colon branch August 24, 2017 07:03
@GeoffreyBooth GeoffreyBooth mentioned this pull request Aug 24, 2017
Closed
@GeoffreyBooth GeoffreyBooth mentioned this pull request Sep 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lydell lydell lydell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GeoffreyBooth @lydell