[CS2] Fix #4589: Don’t unnecessarily escape quotes in template literals #4660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, so that quotation marks are not unnecessarily escaped in backtick-delimited strings/template literals
GeoffreyBooth
changed the title
Contributor
|
If all the tests pass, then LGTM. Previous bugs possibly affected by this: #4380. StringWithInterpolations.compileNode() looks way more complicated than last time I looked at it! |
Collaborator
Author
This was referenced Aug 27, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4589.
"a\"#{1}\"b"now becomes`a"${1}"b`, not`a\"${1}\"b`. @greghuc @xixixao.Yes, this PR changes only four characters.