Fix browser tests #4378
Merged
Fix browser tests #4378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite` into the `doc:site` task
…dded inside it; update test.html styles; move UTF-8 comment test out of test.html and into test/comments.coffee where it belongs
…t.html, into one file that can be included into both
…sted Underscore; handle .litcoffee correctly
…uns them; most importantly, tests fail when the `test` function throws an exception, not when `ok` does (which happens intentionally a few times in the classes tests); this also produces a more accurate count of tests run
|
Thanks for getting these up and running again! |
This was referenced Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets
test.htmlworking in the browser again. It had fallen a few years behind how tests were run inCakefile, and over that time many tests started using helper functions from Node’sassertthat aren’t available in the browser; andtest.html‘s method of checking for test passes/fails diverged at some point fromCakefile‘s, so there were false positives (or incorrect negatives?) in thetest.htmltest results. This PR fixes all of this, and refactorsCakefileandtest.htmlso that shared code is not duplicated. The test for UTF-8 characters in comments (#4375) has been moved fromtest.htmlintotest/comments.coffee.I didn’t commit any generated files output under
docsbecause I don’t want to influence the current docs, so to see this in action after you’ve checked out this branch:cake build:browsercake doc:sitedocs/v1/test.htmlin a browser (afile://link is fine)