Disallow exporting anonymous classes #4339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classes (previously we were outputting invalid JavaScript that the runtime was erroring on)
|
Oh, cool, didn't notice it was fixed right after the report! Thank you very much :) |
|
Yes, it will go out with the next release. The current generated code for this edge case isn’t valid JavaScript, so the runtime should already be throwing an error; and then when the next point release goes out with this fix, the compiler will catch the error before the runtime does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment.
We had a test for making sure the compiler wasn’t allowing
export class(without a name given for the class) but it was a poorly written test, and wasn’t actually checking that the export wasn’t happening. The error message it was checking for was actually getting thrown by the Node runtime (for not understanding theexportkeyword) rather than checking that anonymous classes can’t be exported.I added a check in
nodes.coffeethat exported classes have names, and I fixed the test.