Unify, simplify and fixup assignment errors #4221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lexer.coffee
Outdated
| skipToken = true | ||
| if prev and prev.variable | ||
| origin = prev.origin ? prev | ||
| if message = isUnassignable prev[1], origin[1] |
There was a problem hiding this comment.
I find this pattern of doing an assignment in a condition really unreadable and error-prone.
There was a problem hiding this comment.
Fixed all occurrences in the diff.
- Show the same type of error message for compound assignment as for `=` assignment when the LHS is invalid. - Show the same type of error message when trying to assign to a CoffeeScript keyword as when trying to assign to a JavaScript keyword. - Now longer treat `&& =` as `&&=`. The same goes for `and=`, `||=` and `or=`. - Unify the error message to: `<optional type> '<value>' can't be assigned`.
lydell
force-pushed
the
assignment-errors
branch
from
47f5573 to
4d8cd03
Compare
michaelficarra
added a commit
that referenced
this pull request
Mar 6, 2016
Unify, simplify and fixup assignment errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=assignment when the LHS is invalid.
keyword as when trying to assign to a JavaScript keyword.
&& =as&&=. The same goes forand=,||=andor=.<optional type> '<value>' can't be assigned.