process.argv behaves differently to nodejs

[chrislloyd]

In a file (both valid coffee script and vanilla JS):

console.log(process.argv)

then call with:

$ node argv.js -myargs
[ 'node', '/Users/Chris/Desktop/argv.js', '-myargs' ]

and

$ coffee argv.js -myargs
[ 'coffee',
  '/Users/Chris/Desktop/argv.js',
  '-m',
  '-y',
  '-a',
  '-r',
  '-g',
  '-s' ]

CoffeScript still interprets flags after the script name.

[yuchi]

I'm not sure, but I think it's a feature.

Update: as expected, this is a feature. - args are flags, and you should be able to search for them directly as -m,-y,-a,-r,-g,-s. The -- args are long name arguments, so these are not broke into flags. just try with

    > coffee test.js --myargs

[michaelficarra]

A quick look yielded some results. normalizeArguments is changing the args list passed to OptionParser::parse so that it can iterate over the single-char options separately when given in that compressed style. When it sees a non-option argument (like the filename), it returns the remaining arguments... but they've already been split apart. Doesn't seem like an easy fix.

edit: node doesn't have to parse the compressed (POSIX?) style arguments, since they don't accept them. Lucky them.

edit: thought of a solution: keep the original argument list and do an indexOf to find the non-option argument in the original list and slice from there. assigning it to me.

[michaelficarra]

@yuchi: coffee should not be normalising the arguments passed to scripts; only the ones it is handling. This is a bug.

[yuchi]

Ops... looks like the correct behaviour to me. Thanks @michaelficarra

[michaelficarra]

@chrislloyd: fixed by e686e3f

[chrislloyd]

Bam! That's service for you. Thanks!

[felixrabe]

I'm afraid this issue is not resolved.

$ cat argv.js
console.log(process.argv)

$ node -v
v0.10.9

$ coffee -v
CoffeeScript version 1.6.2

$ node argv.js -myargs
[ 'node',
  '/path/to/argv.js',
  '-myargs' ]

$ coffee argv.js -myargs
[ 'coffee',
  '/path/to/argv.js',
  '-m',
  '-y',
  '-a',
  '-r',
  '-g',
  '-s' ]

[felixrabe]

I just verified that e686e3f really did fix this issue. There must have been a regression in the meantime.

$ pwd
/path/to/coffee-script

$ echo 'console.log(process.argv)' > ./argv.js

$ git checkout -b test-before e686e3f6e9b47949f12567d04dd25eae63ed3ce5~
Switched to a new branch 'test-before'

$ ./bin/coffee argv.js -myargs
path.exists is now called `fs.exists`.
[ 'coffee',
  '/path/to/coffee-script/argv.js',
  '-m',
  '-y',
  '-a',
  '-r',
  '-g',
  '-s' ]

$ git checkout -b test-after e686e3f6e9b47949f12567d04dd25eae63ed3ce5
Switched to a new branch 'test-after'

$ ./bin/coffee argv.js -myargs
path.exists is now called `fs.exists`.
[ 'coffee',
  '/path/to/coffee-script/argv.js',
  '-myargs' ]

Please reopen this issue. I will comment again with the commit that re-introduced the bug and then leave it to you (unless a fix is obvious to me).

[felixrabe]

The bug was re-introduced in c0dac45: (and never "re-fixed" in the meantime)

c0dac45 OptionParser and related tests needed a cleanup

Bisection:

$ git log --pretty=oneline --abbrev-commit test-after..master src/optparse.coffee
7be996c code cleanup
c0dac45 OptionParser and related tests needed a cleanup
e2a205a making use of slicing syntax
fc0a169 fixes #1910: loop index should be mutable within a loop iteration and immutable between loop iterations
054fe34 fixes #1754: support filenames starting with `-` by using `--` arg

$ git checkout -B test 054fe34
Switched to a new branch 'test'

$ ./bin/coffee argv.js -myargs
path.exists is now called `fs.exists`.
[ 'coffee',
  '/path/to/coffee-script/argv.js',
  '-myargs' ]

$ git checkout -B test fc0a169
Reset branch 'test'

$ ./bin/coffee argv.js -myargs
[ 'coffee',
  '/path/to/coffee-script/argv.js',
  '-myargs' ]

$ git checkout -B test e2a205a
Reset branch 'test'

$ ./bin/coffee argv.js -myargs
[ 'coffee',
  '/path/to/coffee-script/argv.js',
  '-myargs' ]

$ git checkout -B test c0dac45
Reset branch 'test'

$ ./bin/coffee argv.js -myargs
[ 'coffee',
  '/path/to/coffee-script/argv.js',
  '-m',
  '-y',
  '-a',
  '-r',
  '-g',
  '-s' ]

$ git checkout -B test 7be996c
Reset branch 'test'

$ ./bin/coffee argv.js -myargs
[ 'coffee',
  '/path/to/coffee-script/argv.js',
  '-m',
  '-y',
  '-a',
  '-r',
  '-g',
  '-s' ]

[vendethiel]

Thanks for finding c0dac45 :).

[felixrabe]

Well, thanks for fixing it :)

[xixixao]

The desired behavior is achieved by

$ ./bin/coffee argv.js -- -myargs
[ 'coffee',
  '/path/to/coffee-script/argv.js',
  '-myargs']

Close?