This repository was archived by the owner on Jul 4, 2025. It is now read-only.
feat: engine management #1546
Merged
feat: engine management #1546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namchuai
commented
Oct 25, 2024
namchuai
force-pushed
the
j/engine-management
branch
3 times, most recently
from
308068c to
3dba0ce
Compare
namchuai
force-pushed
the
j/engine-management
branch
from
549f1ef to
3edfb66
Compare
namchuai
commented
Oct 30, 2024
namchuai
force-pushed
the
j/engine-management
branch
4 times, most recently
from
2a4662c to
d344f30
Compare
namchuai
commented
Oct 30, 2024
namchuai
force-pushed
the
j/engine-management
branch
from
d344f30 to
027bb54
Compare
Contributor
|
Preview URL: https://2caa50b4.cortex-docs.pages.dev |
namchuai
force-pushed
the
j/engine-management
branch
2 times, most recently
from
63cca4f to
76481c5
Compare
namchuai
force-pushed
the
j/engine-management
branch
from
76481c5 to
e7c3eb6
Compare
namchuai
force-pushed
the
j/engine-management
branch
from
e7c3eb6 to
6dc872d
Compare
namchuai
force-pushed
the
j/engine-management
branch
from
6dc872d to
ec7c566
Compare
namchuai
force-pushed
the
j/engine-management
branch
from
ec7c566 to
554ecb0
Compare
vansangpfiev
reviewed
Nov 4, 2024
vansangpfiev
approved these changes
Nov 4, 2024
namchuai
force-pushed
the
j/engine-management
branch
from
79b7d5c to
48b09fe
Compare
namchuai
force-pushed
the
j/engine-management
branch
2 times, most recently
from
3eef24d to
edfa86e
Compare
namchuai
force-pushed
the
j/engine-management
branch
from
dc2aea0 to
4b693f5
Compare
vansangpfiev
reviewed
Nov 5, 2024
|
|
||
| auto on_finished = [engine](const DownloadTask& finishedTask) { | ||
| auto engine_path = file_manager_utils::GetEnginesContainerPath() / engine; | ||
| auto engine_path = file_manager_utils::GetCudaToolkitPath(engine); |
Contributor
There was a problem hiding this comment.
Should we rename to cuda_path?
Contributor
Author
There was a problem hiding this comment.
will update in following pr.
vansangpfiev
approved these changes
Nov 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
nlohmann::jsonInferenceService, moving engine logic toEngineServiceFixes Issues
Self Checklist