Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: correct model_id in chat #1379

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: correct model_id in chat #1379

merged 3 commits into from
Oct 1, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 1, 2024 •
edited by gabrielle-ong
Loading

Describe Your Changes

  • Add /models/start and /models/stop endpoint
  • Fallback to cortex.llamacpp if engine is not in request body
  • Use model_handle for model chat id

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 1, 2024 08:40
namchuai
namchuai reviewed Oct 1, 2024
View reviewed changes
namchuai
namchuai approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit 58ec4f9 into dev Oct 1, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/chat branch October 1, 2024 08:48
@gabrielle-ong gabrielle-ong mentioned this pull request Oct 2, 2024
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

1 more reviewer

@namchuai namchuai namchuai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: No engine field in request body

3 participants

@vansangpfiev @namchuai