Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: make cortex models stop works again #1364

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: make cortex models stop works again #1364

merged 1 commit into from
Sep 30, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 30, 2024 •
edited
Loading

Describe Your Changes

We missed cortex models stop command when worked with new models data structure.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 30, 2024 11:26
@vansangpfiev vansangpfiev merged commit 93bce74 into dev Sep 30, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/model-stop branch September 30, 2024 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

1 more reviewer

@namchuai namchuai namchuai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Model download fails due to YAML::BadFile

4 participants

@vansangpfiev @namchuai @sangjanai