Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

feat: cortex ps #1345

Merged
merged 1 commit into from
Sep 30, 2024
Merged

feat: cortex ps #1345

merged 1 commit into from
Sep 30, 2024
+147 −7

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 26, 2024 •
edited by gabrielle-ong
Loading

Describe Your Changes

  • Add cortex ps command.

Screenshots

Screenshot 2024-09-26 at 17 59 42

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai marked this pull request as ready for review September 30, 2024 01:49
@namchuai namchuai requested review from dan-menlo, nguyenhoangthuan99 and vansangpfiev and removed request for dan-menlo and vansangpfiev September 30, 2024 01:49
vansangpfiev
vansangpfiev reviewed Sep 30, 2024
View reviewed changes
@namchuai
Copy link
Contributor Author

namchuai commented Sep 30, 2024

Thanks guys, force push for rebasing

@namchuai namchuai merged commit a5a1877 into dev Sep 30, 2024
4 checks passed
@namchuai namchuai deleted the j/cortex-ps branch September 30, 2024 04:16
@gabrielle-ong gabrielle-ong mentioned this pull request Oct 3, 2024
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

2 more reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

epic: cortex ps and Process Status

4 participants

@namchuai @vansangpfiev @nguyenhoangthuan99