Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 23, 2024

Describe Your Changes

Syntax:
-s, --source: local folder source to install engine

cortex engines install <engine_name> -s <source_path>
  • If source_path contains engine → unzip engine to installation directory
  • If source_path does not contain engine → fallback to download engine path

The same logic for CUDA dependencies

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 23, 2024 01:46
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ some small nits. Looks good to me overally!

Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @vansangpfiev. A few follow-up questions:

  • For --source, will it take a folder or a file?
  • Is it a folder since CUDA dependencies and llamacpp tar.gz are different files?

I will let the engineers scrutinize for code convention.

@vansangpfiev
Copy link
Contributor Author

Lgtm, thanks @vansangpfiev. A few follow-up questions:

  • For --source, will it take a folder or a file?
  • Is it a folder since CUDA dependencies and llamacpp tar.gz are different files?

I will let the engineers scrutinize for code convention.

It is a folder

@vansangpfiev vansangpfiev merged commit 1e7c2ac into dev Sep 23, 2024
@vansangpfiev vansangpfiev deleted the feat/install-local-engine branch September 23, 2024 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants