Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 20, 2024

Describe Your Changes

  • Add download resume functionality.

Screenshots

  1. If cortex found that the file haven't fully downloaded, will ask if user want to continue (resume)
Screenshot 2024-09-20 at 14 21 35
  1. If file is already downloaded, will ask if user want to redownload or ignore
Screenshot 2024-09-20 at 14 23 10

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, will let @vansangpfiev @nguyenhoangthuan99 verify for code quality

@namchuai namchuai force-pushed the j/add-download-resume branch from 69ba6a2 to 1bbb4c7 Compare September 20, 2024 08:28
@dan-menlo
Copy link
Contributor

@namchuai Quick check: how will Jan get the download progress from Cortex, in order to display the download progress indicator?

@namchuai
Copy link
Contributor Author

@namchuai Quick check: how will Jan get the download progress from Cortex, in order to display the download progress indicator?

We haven't decided yet. I think we have the couple of choices:

  1. Via API server sent event API and client (e.g, Jan) can connect to and listen to event from cortex (download event, hardware consuming event, model starting/ stopping event, etc.)
  2. Via socket. (or any other IPC mechanism)
    cc @vansangpfiev @nguyenhoangthuan99 if you have any suggestion.

IMO, 1 is faster to implement and relatively easy for 3rd party app to adopt. However, I haven't played with Drogon's stream API and SSE though.

@namchuai namchuai merged commit d3ba576 into dev Sep 20, 2024
@namchuai namchuai deleted the j/add-download-resume branch September 20, 2024 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants