This repository was archived by the owner on Jul 4, 2025. It is now read-only.
Feat Installer and CICD nightly, beta, stable for cortexcpp #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiento09
force-pushed
the
feat/installer-windows
branch
from
f673cab to
b246149
Compare
hiento09
changed the title
hiento09
force-pushed
the
feat/installer-windows
branch
from
9d1cc89 to
21d9633
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
21d9633 to
3c9aa62
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
3c9aa62 to
1038088
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
1038088 to
58c2862
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
58c2862 to
93851e9
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
d9646e3 to
67e20a8
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
2 times, most recently
from
c0de7d6 to
2b14638
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
2b14638 to
32c50b7
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
32c50b7 to
c2d1c66
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
2 times, most recently
from
d9f63f2 to
2e82710
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
dfc11c0 to
c0e4191
Compare
hiento09
requested review from
dan-menlo,
namchuai,
nguyenhoangthuan99 and
vansangpfiev
hiento09
changed the title
hiento09
force-pushed
the
feat/installer-windows
branch
from
c0e4191 to
c65a648
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
c65a648 to
2815191
Compare
hiento09
changed the title
hiento09
force-pushed
the
feat/installer-windows
branch
from
a7378fe to
ff328ab
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
ff328ab to
c3aaa84
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
c3aaa84 to
a102fd7
Compare
hiento09
force-pushed
the
feat/installer-windows
branch
from
a102fd7 to
4fdec02
Compare
dan-menlo
approved these changes
Sep 11, 2024
Contributor
dan-menlo
left a comment
dan-menlo
left a comment
There was a problem hiding this comment.
@hiento09 I am approving this PR first as I don't want things to block things. I've left a few questions to help my understanding, if you don't mind.
Also, in future, I recommend breaking up a massive PR like this into smaller bite-sized ones:
- Per-OS PRs (e.g. linux, macos, windows)
- Helps discoverability, and clearer traceability for engineers
dan-menlo
changed the title
Contributor
|
@hiento09 FYI, I encountered a bug running
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR does
Fixes Issues
You can try our installer at