This repository was archived by the owner on Jul 4, 2025. It is now read-only.
feat: cortex update command #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
force-pushed
the
feat/cortex-update-cmd
branch
from
bbb9bf3 to
e950285
Compare
Contributor
|
Nice one! I have one question. What happen in windows, if the server is running, then our executable will be in used, right? ? will |
namchuai
reviewed
Sep 6, 2024
namchuai
reviewed
Sep 6, 2024
namchuai
reviewed
Sep 6, 2024
namchuai
approved these changes
Sep 6, 2024
Contributor
namchuai
left a comment
namchuai
left a comment
There was a problem hiding this comment.
✅ Looks good. Just some small nits. Not required though.
nguyenhoangthuan99
approved these changes
Sep 6, 2024
Contributor
Author
We cannot replace but can remove file on windows if it is in used. |
Contributor
|
I am removing this from Project Board:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1087
Only support to download latest version for now
Also added
cortex -vcommand#1066