Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

bug: cortex pull invalid_url creates a model folder #1270

@freelerobot

Description

@freelerobot

Cortex version

v70

Describe the Bug

  1. cortex pull https://huggingface.co/cortexso/NONEXISTENT_MODEL
  2. Get "model downloaded successfully"
  3. Get "not a valid GGUF file"
  4. run ls /cortexcpp/models
  5. See that a model folder was created for "nonexistent model name"
❯ sudo cortex-nightly pull https://huggingface.co/cortexso/mistraaal
Validating download items, please wait..
Start downloading: mistraaal
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 17228  100 17228    0     0  58595      0 --:--:-- --:--:-- --:--:-- 58798
Model mistraaal downloaded successfully!
Not a valid GGUF file
❯ ls
mistraaal    

Questions

  1. Whats our model download validation sequence?
  2. Is this a race condition or just bad sequencing?

What is your OS?

  • MacOS
  • Windows
  • Linux

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions