Skip to content

feat: add direct urls for comments #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2023
Merged

feat: add direct urls for comments #98

merged 1 commit into from
Jun 6, 2023

Conversation

@tuunit
Copy link
Collaborator

@tuunit tuunit commented Jun 3, 2023 •
edited
Loading

  • add direct urls for comments
  • replace custom url handling with html_url property provided by github api

fixes #54

has been tested here:

https://github.com/tuunit/github-activity-testing
https://github.com/tuunit/github-activity-testing/actions/runs/5165369229

@tuunit tuunit requested a review from jamesgeorge007 June 3, 2023 19:55
@tuunit tuunit mentioned this pull request Jun 3, 2023
Closed
jamesgeorge007
jamesgeorge007 requested changes Jun 4, 2023
View reviewed changes
@jamesgeorge007 jamesgeorge007 changed the title add direct urls for comments feat: add direct urls for comments Jun 4, 2023
@jamesgeorge007
Copy link
Owner

jamesgeorge007 commented Jun 4, 2023

@tuunit, let's follow conventional commits for the PR titles and commit messages. Also, are you planning to include only this commit in the next release; in that case, let's have the version bump in this PR as well. Since this is an enhancement I think it should be a minor bump to v0.5.0.

@tuunit
Copy link
Collaborator Author

tuunit commented Jun 4, 2023 •
edited
Loading

@tuunit, let's follow conventional commits for the PR titles and commit messages. Also, are you planning to include only this commit in the next release; in that case, let's have the version bump in this PR as well. Since this is an enhancement I think it should be a minor bump to v0.5.0.

@jamesgeorge007 Yeah, perfect I'm a fan of the conventional commit standard. It is used in all official google cloud repositories as well. I was thinking about that and was considering to upgrade to v0.5.0 but then decided against it. Because it seems like such a minor change but obviously you are right, it is essentially a new feature and therefore I bumped the version to v0.5.0

@tuunit @jamesgeorge007
feat: add direct urls for comments
5a76944 
- add direct urls for comments and replace custom url handling with html_url property provided by github api
- remove redundant else branches
- separate into if blocks for better readability
- remove unnecessary constant for github base url

Co-authored-by: James George <[email protected]>
@tuunit
Copy link
Collaborator Author

tuunit commented Jun 4, 2023 •
edited
Loading

@jamesgeorge007 All changes are done and I squashed the commits and changed the commit message to follow the conventional standard 🥳

@jamesgeorge007
Copy link
Owner

jamesgeorge007 commented Jun 5, 2023

@tuunit, there is a regression with the URL generated for releaseEvent #99. Let's include a fix for the same in this release. Let's create an RC branch and target this PR to the same.

@tuunit tuunit changed the base branch from master to rc/0.5.0 June 6, 2023 07:45
@tuunit tuunit merged commit a5ec258 into jamesgeorge007:rc/0.5.0 Jun 6, 2023
@tuunit tuunit mentioned this pull request Jun 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Link to direct issue/PR comment

2 participants

@tuunit @jamesgeorge007