This repository was archived by the owner on Nov 27, 2023. It is now read-only.
FORMS-821: Used OS2Web datalookup for CPR and CVR data #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/FORMS-821-data-lookup
branch
3 times, most recently
from
26d1ef9 to
c204c21
Compare
jekuaitk
reviewed
May 9, 2023
src/Commands/CommandsSF1601.php
Outdated
Comment on lines
216
to
225
| private function forsendelseDump(string $dump, ForsendelseI $forsendelse) { | ||
| switch ($dump) { | ||
| case self::HIDDEN_CONTENT: | ||
| break; | ||
|
|
||
| default: | ||
| throw new InvalidOptionException(sprintf( | ||
| 'Invalid dump option %s. Must be one of %s', | ||
| json_encode($dump), | ||
| implode(', ', array_map('json_encode', self::MEMO_DUMP_OPTION_VALUES)) |
There was a problem hiding this comment.
This doesn't seem to do anything interesting, but im guessing it's gonna be expanded upon later?
There was a problem hiding this comment.
Maybe … But I don't think so … 9b0bd69#diff-277313824881e121c257dfac232862fef0d2320ab160c36610bdda1d75c27b88R225
rimi-itk
force-pushed
the
feature/FORMS-821-data-lookup
branch
5 times, most recently
from
a613edb to
a4f512e
Compare
jekuaitk
approved these changes
May 10, 2023
rimi-itk
force-pushed
the
feature/FORMS-821-data-lookup
branch
from
b8461ea to
49aa3c8
Compare
jekuaitk
reviewed
Aug 4, 2023
composer.json
Outdated
| "ext-soap": "*", | ||
| "dompdf/dompdf": "^2.0", | ||
| "drupal/webform": "^6.0", | ||
| "drush/drush": "^10 || ^11", |
Comment on lines
+87
to
+88
| // @see https://digitaliseringskataloget.srvitkhulk.itkdev.dk/digitaliseringskataloget.dk/sf1601/SF1601%20Bilag%2020211025/SF1601%20Postkomponent%20-%20KombiPostAfsend%20-%20Feltbeskrivelse.pdf#page=7 | ||
| $afsendelseModtager->setCPRnummerIdentifikator('0000000000'); |
jekuaitk
approved these changes
Aug 4, 2023
rimi-itk
force-pushed
the
feature/FORMS-821-data-lookup
branch
from
6a4decd to
7758a62
Compare
jekuaitk
approved these changes
Aug 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.itkdev.dk/browse/FORMS-821