This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Beskedfordeler #32
Merged
Beskedfordeler #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekuaitk
approved these changes
Feb 14, 2023
src/Helper/BeskedfordelerHelper.php
Outdated
| ->execute() | ||
| ->fetchAll(\PDO::FETCH_CLASS, Message::class); | ||
|
|
||
| return reset($messages) ?: NULL; |
There was a problem hiding this comment.
Why reset()? Could there ever be more than one?
There was a problem hiding this comment.
No, but $messages is a list of messages and I want just a single one.
rimi-itk
force-pushed
the
feature/beskedfordeler
branch
from
d5fa77d to
cecdf2a
Compare
rimi-itk
force-pushed
the
feature/beskedfordeler
branch
from
4381d32 to
5f6ad82
Compare
rimi-itk
force-pushed
the
feature/beskedfordeler
branch
from
5f6ad82 to
8d14b34
Compare
jekuaitk
reviewed
Feb 14, 2023
| return; | ||
| } | ||
|
|
||
| if ($this->beskedfordelerHelper->addBeskedfordelerMessage($messageUUID, $message) > 0) { |
There was a problem hiding this comment.
I suppose this a check for whether the call to addBeskedfordelerMessage went ok, but it just looks funny and took me a while to understand.
jekuaitk
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration with Beskedfordeler.