Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Conversation

@lats1
Copy link
Contributor

@lats1 lats1 commented Jun 29, 2021

No description provided.

@lats1 lats1 requested a review from rimi-itk June 29, 2021 09:10
Copy link
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some comments have been added.


$listOfTemplates = $this->templateManager->getAvailableTemplates();

$form['template'] = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be required?

$form['channel'] = [
'#type' => 'select',
'#title' => $this->t('Select channel'),
'#options' => [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment on where we get these values (D, F …) from may be useful here.

@lats1 lats1 requested a review from rimi-itk June 29, 2021 12:14
@lats1 lats1 requested a review from rimi-itk July 8, 2021 08:23
@lats1 lats1 marked this pull request as ready for review July 8, 2021 09:19
@lats1 lats1 merged commit f84f043 into develop Jul 8, 2021
@lats1 lats1 deleted the feature/pdf-templates branch July 8, 2021 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants