Skip to content

add rama chavali to toc #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 21, 2025
Merged

add rama chavali to toc #1653

merged 5 commits into from
Aug 21, 2025

Conversation

@ramaraochavali
Copy link
Contributor

I want to join the Istio org!

@ramaraochavali ramaraochavali requested a review from a team as a code owner August 20, 2025 09:54
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2025
@ramaraochavali
Copy link
Contributor Author

@linsun @louiscryan fyi

@ramaraochavali
Copy link
Contributor Author

/test lint

keithmattix
keithmattix reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably also should change teams.yaml right?

@ramaraochavali
Copy link
Contributor Author

ramaraochavali commented Aug 20, 2025 via email

@ramaraochavali
update teams
f2fed44 
Signed-off-by: Rama Chavali <[email protected]>
kfaseela
kfaseela reviewed Aug 20, 2025
View reviewed changes
@ramaraochavali
alpha order
7f85331 
Signed-off-by: Rama Chavali <[email protected]>
@ramaraochavali
Copy link
Contributor Author

@kfaseela Lint failure is not related to my change. What shall I do?

@kfaseela
Copy link
Member

/test lint

@kfaseela
Copy link
Member

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_community 7f85331 link true /test lint

seems to be failing on other PRs as well. eg: #1654 will take a look

@kfaseela
Copy link
Member

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
lint_community 7f85331 link true /test lint

seems to be failing on other PRs as well. eg: #1654 will take a look

Line 100 in README:
Issues :-(

Links

  1. [L100] 403 https://time.is/compare/1000_in_San_Francisco%2c_California

Will fix in a separate PR and see

@kfaseela kfaseela mentioned this pull request Aug 21, 2025
Merged
@kfaseela
Copy link
Member

/retest

kfaseela
kfaseela approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@kfaseela kfaseela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations @linsun @louiscryan and @ramaraochavali !

craigbox
craigbox reviewed Aug 21, 2025
View reviewed changes
TECH-OVERSIGHT-COMMITTEE.md
<img width="30px" src="https://avatars.githubusercontent.com/u/84202?s=400&v=4">| [Costin Manolache](https://github.com/costinm) | Google | 2025
<img width="30px" src="https://pbs.twimg.com/profile_images/838075233445695489/o2eAYJAV_400x400.jpg"> | [Louis Ryan](https://github.com/louiscryan) | Solo.io | 2027
<img width="30px" src="https://avatars1.githubusercontent.com/u/1588319?s=400&v=4"> | [Lin Sun](https://github.com/linsun) | Solo.io | 2027
<img width="30px" src="https://avatars.githubusercontent.com/u/17204904?v=4">| [Rama Chavali](https://github.com/ramaraochavali) | Salesforce | 2027
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the end of the world but these were previously sorted alphabetically by surname

@istio-testing istio-testing merged commit a58b7cd into istio:master Aug 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigbox craigbox craigbox left review comments

@keithmattix keithmattix keithmattix left review comments

@kfaseela kfaseela kfaseela approved these changes

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ramaraochavali @kfaseela @craigbox @keithmattix @istio-testing