Skip to content

Emap2 patch 1 #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Emap2 patch 1 #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fbbff3
Update package.json
emap2 May 18, 2017
968ae70
Update isteven-multi-select.js
emap2 May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions isteven-multi-select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect'
var clickedEl = element.children()[0];

// Just to make sure.. had a bug where key events were recorded twice
angular.element( document ).off( 'click', $scope.externalClickListener );
angular.element( document ).off( 'click touchstart', $scope.externalClickListener );
angular.element( document ).off( 'keydown', $scope.keyboardListener );

// The idea below was taken from another multi-select directive - https://github.com/amitava82/angular-multiselect
Expand All @@ -611,7 +611,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect'

angular.element( checkBoxLayer ).removeClass( 'show' );
angular.element( clickedEl ).removeClass( 'buttonClicked' );
angular.element( document ).off( 'click', $scope.externalClickListener );
angular.element( document ).off( 'click touchstart', $scope.externalClickListener );
angular.element( document ).off( 'keydown', $scope.keyboardListener );

// clear the focused element;
Expand Down Expand Up @@ -643,7 +643,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect'

// Attach change event listener on the input filter.
// We need this because ng-change is apparently not an event listener.
angular.element( document ).on( 'click', $scope.externalClickListener );
angular.element( document ).on( 'click touchstart', $scope.externalClickListener );
angular.element( document ).on( 'keydown', $scope.keyboardListener );

// to get the initial tab index, depending on how many helper elements we have.
Expand Down Expand Up @@ -697,7 +697,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect'

angular.element( checkBoxLayer.previousSibling ).removeClass( 'buttonClicked' );
angular.element( checkBoxLayer ).removeClass( 'show' );
angular.element( document ).off( 'click', $scope.externalClickListener );
angular.element( document ).off( 'click touchstart', $scope.externalClickListener );
angular.element( document ).off( 'keydown', $scope.keyboardListener );

// close callback
Expand Down
5 changes: 1 addition & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
"name": "isteven-angular-multiselect",
"version": "v4.0.0",
"description": "A multi select dropdown directive for AngularJS",
"main": [
"isteven-multi-select.js",
"isteven-multi-select.css"
],
"main":"isteven-multi-select.js",
"repository": {
"type": "git",
"url": "https://github.com/isteven/angular-multi-select.git"
Expand Down