Skip to content

Conversation

kosukeohmura
Copy link

クエリパラメータが配列の場合、クエリストリングを(キー)[]=バリューの形で作成したかったので Fork させていただきました。

@ishkawa
Copy link
Owner

ishkawa commented Mar 19, 2017

ありがとうございます!

同一キーの複数値については表現方法があり、APIKit 3の時点ではどれもサポートしていませんでした。 #229 でクエリパラメーターの組み立てのためのプロトコルが導入されたので、こちらで対応できる見込みです。現時点のAPIKit 3への導入は、破壊的を避けるために見送ろうと思います。


Thank you for the PR!

Multiple values for the same key is not supported in APIKit 3. #229 introduces a protocol that abstracts building query parameters, and I think this support the use case. To avoid breaking changes, I postpone this for APIKit 3.

@ishkawa ishkawa closed this Mar 19, 2017
@kosukeohmura
Copy link
Author

Thanks for the response. That seems better than my code.
When will APIKit 4 be released? After the release of Swift 4?

@ishkawa
Copy link
Owner

ishkawa commented Mar 30, 2017

I think it'll be released within a month 😄
The main changes are #229 and #234.

@kosukeohmura
Copy link
Author

Cool!

417-72KI added a commit to 417-72KI/APIKit that referenced this pull request Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants