-
-
Notifications
You must be signed in to change notification settings - Fork 58
Improve public API docs #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: multiversion/dev
Are you sure you want to change the base?
Improve public API docs #706
Conversation
86ba14e to
8e0e979
Compare
| ```kotlin | ||
| dependencies { | ||
| // You can change "compileOnly" to "implementation" for testing in-game. | ||
| compileOnly("dev.isxander:controlify:${project.controlify_version}") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like compileOnlyMod should be used instead when using Fabric Loom.
| // vanilla key mappings due explicit native support. | ||
| // You could also use ".keyEmulation(MyModKeyMappings.ACTION) to emulates | ||
| // the vanilla KeyMapping behavior, which may not always work well. | ||
| .addKeyCorrelation(MyModKeyMappings.ACTION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should point out to consumers that they need to either use keyEmulation or addKeyCorrelation. There is no point in using both, since keyEmulation already calls addKeyCorrelation internally.
Updates the documentation and Javadocs to make it more user-friendly and simplify integration with Controlify by:
dev.isxander.controlify.api.entrypoint.ControlifyEntrypointto make it easier for NeoForge users to create in their IDE or terminal.onControlifyInitandonControlifyPreInitto resolve common confusion.Related Issues