Fix crash in neoforge <1.21.9 with AbstractWidgetMixin #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2025
skylect-dev
approved these changes
Oct 18, 2025
|
Tested and verified this works. |
EchoEllet
approved these changes
Oct 18, 2025
EchoEllet
added a commit
to EchoEllet/Controlify
that referenced
this pull request
Oct 23, 2025
EchoEllet
added a commit
to EchoEllet/Controlify
that referenced
this pull request
Oct 23, 2025
EchoEllet
added a commit
to EchoEllet/Controlify
that referenced
this pull request
Oct 23, 2025
EchoEllet
added a commit
to EchoEllet/Controlify
that referenced
this pull request
Oct 23, 2025
EchoEllet
added a commit
to EchoEllet/Controlify
that referenced
this pull request
Oct 23, 2025
4 tasks
EchoEllet
reviewed
Nov 1, 2025
| //? if >=1.21.9 { | ||
| target = "Lnet/minecraft/client/gui/components/AbstractWidget;onClick(Lnet/minecraft/client/input/MouseButtonEvent;Z)V" | ||
| //?} else { | ||
| //?} elif fabric { |
Contributor
There was a problem hiding this comment.
Super nit: Since this issue is NeoForge/Forge-specific, as they modify the vanilla method signature, would it be better to check for NeoForge and then use the else case for Fabric?
This approach scales better if Controlify adds another mod loader in the future, and it makes the code’s semantics clearer.
Contributor
Author
There was a problem hiding this comment.
Oh yeah probably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neoforge has an extra int, while Fabric does not.
Fixes #669
Fixes #665