browser compatibility

[daviddias]

#485 (comment)

[victorb]

Issue is this:

CI is finally green, browsers are not perfect atm, most are failing due to one or the other issue

Firefox fails with this

Firefox 49.0.0 (Linux 0.0.0) ERROR
  SyntaxError: missing = in const declaration
  at webpack:///~/cbor/lib/encoder.js:383:0 <- test/browser.js:41233

though this code runs fine in Chrome.

Which I tracked down to being about either const being used inside for() or using const without a initialize value. So, in the end, turns out the issue is in cbor library we use, specifically here: https://github.com/hildjj/node-cbor/blob/d2d3fee6f9e2beddbf78efa18326ebce2f7f516d/lib/encoder.js#L383

I've submitted a patch here: hildjj/node-cbor#39

[hildjj]

Upgrade to version 3.0.0, includes this and canonicalization.

[daviddias]

Thank you @hildjj !!! 🎉

@victorbjelkholm I've updated ipld/js-ipld-dag-cbor@05170d7 this should be good now :) rerunning CI